ATITD-Tools/Desert-Paint-Codex Changeset

Changeset - 70b1de28b2a2

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Jason Maltzen - 12 months ago 2023-12-03 06:00:18
jason@hiddenachievement.com

Re-enable the ability to save debug screenshots based on a setting value to help debug reaction capturing. Update the README to correctly reflect the debug.screenshot setting name, location of the settings file, and removal of the old debug menu.

2 files changed with 11 insertions and 8 deletions:

README.md

Services/ReactionScannerService.cs

0 comments (0 inline, 0 general)

README.md

➞

Show inline comments

@@ ... / @@ -121,24 +121,23 @@ High DPI screens may be displaying the g @@
 ## Mac user FAQ
 Q: How do I find my native screen resolution?
 A: You can find it by opening up "About this Mac" from the Apple menu and clicking on the "Displays" tab. That should show the screen size and resolution to enter.
 ## Advanced Settings
-The settings file has several advanced options that are not available in the interface. Some of these are for debugging, while others are useful for improving the speed of finding the pigment lab interface. The settings file is found in AppData\Local\DesertPaintLab\settings on Windows, and in ~/.local/share/DesertPaintLab/settings on macOS.
+The settings file has several advanced options that are not available in the interface. Some of these are for debugging, while others are useful for improving the speed of finding the pigment lab interface. The settings file is found in AppData\Local\DesertPaintCodex\settings on Windows, and in ~/.local/share/DesertPaintCodex/settings on macOS.
 * _scanarea.min.x_ sets the starting horizontal offset when searching for the pigment lab. This is useful in multi-screen setups to skip any leftmost displays. For example, a dual-screen setup with two side-by-side 3840x2160 displays where the game runs on the right screen would set this to 3840 to bypass scanning the left display.
 * _scanarea.min.y_ Like scanarea.min.x, but skips the upper section of display
 * _scanarea.max.x_ defines the rightmost edge of the area to scan
 * _scanarea.max.y_ defines the bottom edge of the area to scan
 * _enabledebugmenu_ enables debug tool menu to help track down problems. This also causes DPL to write debug log files during scanning and recipe generation. This can slow down scanning and recipe searching.
 * _debugscreenshot_ automatically saves out a screenshot when searching for the pigment lab to help in debugging
 * _debug.screenshot_ automatically saves out a screenshot when searching for the pigment lab to help in debugging
 * _logging.verbosity_ sets the verbosity of the logging between 0 and 3. The higher the value, the more detail is included in the log file.
 ## For Developers
 This application is written in C#, and it uses the [Avalonia UI Framework](https://avaloniaui.net/). You can learn more about getting set up to use Avalonia [here](https://docs.avaloniaui.net/docs/getting-started/).
 ## Older Versions

Services/ReactionScannerService.cs

➞

Show inline comments

@@ ... / @@ -391,18 +391,25 @@ namespace DesertPaintCodex.Services @@
             IsCaptured = false;
             _recordedColor.Clear();
             using (var g = Graphics.FromImage(_targetBitmap))
+            {
                 Debug.WriteLine("Scan starting at [" + _screenX + ", " + _screenY + "]");
                 g.CopyFromScreen(_screenX, _screenY, 0, 0, _targetBitmap.Size, CopyPixelOperation.SourceCopy);
+            }
             // _targetBitmap.Save(Path.Combine(ProfileManager.CurrentProfile?.Directory ?? "", "screenshot.png"), ImageFormat.Png);
             SettingsService.Get("Log.Verbosity", out var verbosityIdx, 1);
             _logVerbosity = (LogVerbosity)verbosityIdx;
             SettingsService.Get("Debug.Screenshot", out bool debugScreenshot, false);
             if (debugScreenshot)
+            {
                 _targetBitmap.Save(Path.Combine(ProfileManager.CurrentProfile?.Directory ?? "", "screenshot.png"), ImageFormat.Png);
+            }
             Pixels pixels = new(_targetBitmap, _pixelMultiplier);
             IsCaptured = false;
             if (!_firstRun)
+            {
                 // If this is not the first run, let's check the last location, to see if the UI is still there.
                 if (TestPosition(_lastSwatchX, _lastSwatchY, pixels, ref reactedColor))
@@ ... / @@ -410,19 +417,16 @@ namespace DesertPaintCodex.Services @@
                     IsCaptured = true;
                     RecordedColor = reactedColor;
                     return true;
+                }
                 _firstRun = true;
+            }
             SettingsService.Get("Log.Verbosity", out var verbosityIdx, 1);
             _logVerbosity = (LogVerbosity)verbosityIdx;
             int patchTestSize = ((_swatchHeight - _swatchTopBorder - _swatchBottomBorder) / 2) - 1;
             SettingsService.Get("ScanArea.Min.X", out var startX, 0);
             SettingsService.Get("ScanArea.Min.Y", out var startY, 0);
             SettingsService.Get("ScanArea.Max.X", out var endX,   _targetBitmap.Width);
             SettingsService.Get("ScanArea.Max.Y", out var endY,   _targetBitmap.Height);
             startX = Math.Max(2, Math.Min(startX, _targetBitmap.Width - 2));

0 comments (0 inline, 0 general)